This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] headers: avoid bareword attributes

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Thu, 17 Aug 2017 13:54:05 +0200
Subject: Re: [PATCH] headers: avoid bareword attributes
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vinschen at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E30D526B1D
References: <20170817015011.9345-1-eblake@redhat.com>
Reply-to: newlib at sourceware dot org

On Aug 16 20:50, Eric Blake wrote:
> Always use the __-decorated form of an attribute name in public
> headers, as the bareword form is in the user's namespace, and we
> don't want compilation to break just because the user defines the
> bareword to mean something else.

Looks right to me.  Please push, inclkuding the Cygwin patch you
sent to cygwin-patches.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH] headers: avoid bareword attributes
  - From: Eric Blake

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]