This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Changes the default size of time_t to 64 bit.


On Fri, Aug 11, 2017 at 8:23 AM, Freddie Chopin <freddie_chopin@op.pl> wrote:
> On Fri, 2017-08-11 at 13:20 +0200, philipp.trommler@preh.de wrote:
>> +`--enable-32bit-time_t'
>> +     Use a time_t that is defined to long, regardless of the
>> wordsize of
>> +     the target. This may lead to problems in January 2038 when the
>> 32 bit
>> +     timestamp overflows but on the other hand may yield better
>> +     performance than 64 bit timestamps.
>> +     Disabled by default.
>
> I would say that the option is misleading, as "long" may as well have
> 64-bits on 64-bit systems. Maybe it would be better to have it as "
> --disable-64bit-time_t"? This would have a similar issue, but be
> actually  more consistent with the logic of the patch - time_t is
> either 64-bit or whatever "long" is.
>

What about: --enable-time_t-compat to indicate it is a compat-type option
indicating old behaviour?

> Regards,
> FCh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]