This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/7] Adding declaration of reentrant version of inttypes methods.

From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
To: Gedare Bloom <gedare at rtems dot org>, Aditya Upadhyay <aadit0402 at gmail dot com>
Cc: "newlib at sourceware dot org" <newlib at sourceware dot org>
Date: Tue, 25 Jul 2017 14:56:21 +0200
Subject: Re: [PATCH 1/7] Adding declaration of reentrant version of inttypes methods.
Authentication-results: sourceware.org; auth=none
References: <20170724193328.16893-1-aadit0402@gmail.com> <CAC82fA07OyH43HVHLXGPQM217OESrMUN4rUtWn8qZeY7K5Jjew@mail.gmail.com>

On 25/07/17 00:43, Gedare Bloom wrote:

diff --git a/newlib/libc/include/inttypes.h b/newlib/libc/include/inttypes.h
index 25c6e99fa..c2a0483fb 100644
--- a/newlib/libc/include/inttypes.h
+++ b/newlib/libc/include/inttypes.h
@@ -16,10 +16,16 @@
  #include <newlib.h>
  #include <sys/config.h>
  #include <sys/_intsup.h>
+#include "_ansi.h"
+#include <sys/reent.h>


I would prefer a forward declaration

struct _reent;

instead of this include.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

References:
- [PATCH 1/7] Adding declaration of reentrant version of inttypes methods.
  - From: Aditya Upadhyay
- Re: [PATCH 1/7] Adding declaration of reentrant version of inttypes methods.
  - From: Gedare Bloom

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]