This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: newlib at sourceware dot org
- Date: Thu, 22 Jun 2017 10:06:29 +0200
- Subject: Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
- Authentication-results: sourceware.org; auth=none
- References: <1497389420-19708-1-git-send-email-joel@rtems.org> <20170614085049.GR13513@calimero.vinschen.de> <CAOox84uLfx-KNaCyZq=andhtdaN0CkCRUX4Y+Jz6pvVQ4X5E+Q@mail.gmail.com>
On 14/06/17 17:49, Jeff Johnston wrote:
It would have been nicer to ask first, but that said, I am ok with a
clarification added to the definition.
Sorry for the confusion. Since Newlib had already the concept of CPU
Port Maintainers and GCC has CPU/OS Port Maintainers I thought that the
OS Port Maintainers section was just missing when I looked at this file
to add myself to Write After Approval. Joel was missing too, so it
seemed to me that this file was not up to date in general.
For an OS maintainer, changes that add OS-specific changes to existing
shared files need approval. That means you may
make changes to an existing RTEMS section of a header file, but you cannot
add an RTEMS section to a
header or source file that did not have such a section without approval. I
don't want to have RTEMS stuff added all over the
place to save you having to have your own version in your directory.
I think this is clearly stated by:
" OS Port Maintainers (OS alphabetical order)
OS port maintainers may make changes in OS-specific directories, as
well as OS-specific portions of the build system, without approval."
My goal is to get rid of all the __rtems__ defines in shared files.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.