Re: [PATCH] Fix RTEMS ioctl() declaration

[Corinna Vinschen <vinschen at redhat dot com>]

On Jun  7 11:08, Sebastian Huber wrote:
> Using uint32_t for ioctl_command_t does not work well on 64-bit targets.
> 
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
>  newlib/libc/sys/rtems/include/sys/ioccom.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/newlib/libc/sys/rtems/include/sys/ioccom.h b/newlib/libc/sys/rtems/include/sys/ioccom.h
> index 9c5350d1e..2c0e9ee71 100644
> --- a/newlib/libc/sys/rtems/include/sys/ioccom.h
> +++ b/newlib/libc/sys/rtems/include/sys/ioccom.h
> @@ -36,7 +36,7 @@
>  #include <sys/types.h>
>  #include <stdint.h>
>  
> -typedef uint32_t ioctl_command_t;
> +typedef unsigned long ioctl_command_t;

Why do you need a ioctl_command_t at all?  It's not in FreeBSD either.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature