This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, ARM] Fix minor issues in memchr NEON implementation

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Wed, 7 Jun 2017 12:16:50 +0200
Subject: Re: [PATCH, ARM] Fix minor issues in memchr NEON implementation
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5D397BDD4
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5D397BDD4
References: <20170602102256.eyeslc2gyznswpvl@e107464-lin.cambridge.arm.com>
Reply-to: newlib at sourceware dot org

On Jun  2 11:22, Prakhar Bahuguna wrote:
> The NEON-optimised implementation of memchr has a couple of minor issues - it
> does not mask off the higher bits of the input character, and it uses a signed
> comparison instead of unsigned within the smallstr loop. This patch addresses
> both of these issues.
> 
> ChangeLog:
> 
> 2017-06-02  Prakhar Bahuguna  <prakhar.bahuguna@arm.com>
> 
> 	* libc/machine/arm/memchr.S: Add and instruction to mask off all but
> 	the lowest byte.
> 	Change blt to blo.
> 
> Okay for master?

Yes, pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH, ARM] Fix minor issues in memchr NEON implementation
  - From: Prakhar Bahuguna

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]