This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Use of initialized variable in strtod.c


On 03/15/2017 06:36 PM, Joel Sherrill wrote:
But this in __call_atexit.c is definitely correct. It is
treating free() as a weak symbol and the only way to
silence Coverity is to add an annotation.

136      /* Don't dynamically free the atexit array if free is not
137         available.  */

CID 175323 (#1 of 1): Function address comparison (BAD_COMPARE)
func_conv: This implicit conversion to a function pointer is suspicious: free.
       Did you intend to call free?
138      if (!free)
139 break;
This should be able to be gotten rid of easily enough. (I don't see why the "weak" aspect would have anything to do with it.)

For example:
if(free == NULL)
if(!(uintptr_t)free)

Craig


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]