This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
[PATCH 2/2] libc/string/strsignal.c: Use of || not && lead to dead code.
- From: Joel Sherrill <joel at rtems dot org>
- To: newlib at sourceware dot org
- Cc: Joel Sherrill <joel at rtems dot org>
- Date: Wed, 15 Mar 2017 12:41:19 -0500
- Subject: [PATCH 2/2] libc/string/strsignal.c: Use of || not && lead to dead code.
- Authentication-results: sourceware.org; auth=none
- References: <1489599679-1519-1-git-send-email-joel@rtems.org>
Coverity Id: 175333
---
newlib/libc/string/strsignal.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/newlib/libc/string/strsignal.c b/newlib/libc/string/strsignal.c
index 94ae26d..e32c9a7 100644
--- a/newlib/libc/string/strsignal.c
+++ b/newlib/libc/string/strsignal.c
@@ -37,7 +37,7 @@ QUICKREF
/*
* Written by Joel Sherrill <joel.sherrill@OARcorp.com>.
*
- * COPYRIGHT (c) 2010.
+ * COPYRIGHT (c) 2010, 2017.
* On-Line Applications Research Corporation (OAR).
*
* Permission to use, copy, modify, and distribute this software for any
@@ -49,8 +49,6 @@ QUICKREF
* WARRANTY. IN PARTICULAR, THE AUTHOR MAKES NO REPRESENTATION
* OR WARRANTY OF ANY KIND CONCERNING THE MERCHANTABILITY OF THIS
* SOFTWARE OR ITS FITNESS FOR ANY PARTICULAR PURPOSE.
- *
- * $Id$
*/
#include <string.h>
@@ -72,7 +70,7 @@ _DEFUN (strsignal, (signal),
buffer = _REENT_SIGNAL_BUF(ptr);
#if defined(SIGRTMIN) && defined(SIGRTMAX)
- if ((signal >= SIGRTMIN) || (signal <= SIGRTMAX)) {
+ if ((signal >= SIGRTMIN) && (signal <= SIGRTMAX)) {
siprintf (buffer, "Real-time signal %d", signal - SIGRTMIN);
return buffer;
}
--
1.8.3.1