Re: [PATCH, newlib/libc/locale] Fix broken '_duplocale_r' which called '__loadlocale' in an incorrect way

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 12 01:50, Koichi MURASE wrote:
> Hello, I send a patch here.
> 
> Problem:
> 
>   After  passing  locales  created  by  'duplocale'   to   'uselocale',
>   referencing   'MB_CUR_MAX',   which   is   actually   expanded    to
>   '__locale_mb_cur_max()' by preprocessors, causes segmentation faults.
>   Direct use of locales from 'newlocale' does not  cause  the  problem.
>   This is the problem of 'duplocale'.
> [...]
> Bug:
> 
>   In the beginning of '__loadlocale' (newlib/libc/locale/locale.c:501),
>   there is a code which checks if the operations can be skipped:
> 
>   > /* Avoid doing everything twice if nothing has changed. */
>   > if (!strcmp (new_locale, loc->categories[category]))
>   >   return loc->categories[category];
> 
>   While,   in   the   function   '_duplocale_r'    (newlib/libc/locale/
>   duplocale.c), '__loadlocale'  is  called  as  in  the  quoted  codes:
> 
>   > /* If the object is not a "C" locale category, copy it.  Just call
>   >    __loadlocale.  It knows what to do to replicate the category. */
>   > tmp_locale.lc_cat[i].ptr = NULL;
>   > tmp_locale.lc_cat[i].buf = NULL;
>   > if (!__loadlocale (&tmp_locale, i, tmp_locale.categories[i]))
>   >   goto error;
> 
>   This call of '__loadlocale' results in the skip check being
> 
>     !strcmp(tmp_locale.categories[i], tmp_locale.categories[i]),
> 
>   which is always true. This  means  that  the  actual  operations  of
>   '__loadLocale' will never be performed for 'duplocale'.
> 
> Fix:
> 
>   The call of '__loadlocale' in '_duplocale_r' is modified.
> 
>   Please see the attached file for the fix as tabs in  the  mail  body
>   seem to be converted to spaces by Gmail.
> 
> Best regards,
> Koichi Murase

Thanks for tracking this down and fixing.  I applied your patch with
just a bit of code commenting added.


Thanks again,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature