This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] arm: Remove optpld macro

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Cc: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
Date: Thu, 26 Jan 2017 16:33:21 +0100
Subject: Re: [PATCH 2/3] arm: Remove optpld macro
Authentication-results: sourceware.org; auth=none
References: <20170112045019.22610-1-pat.pannuto@gmail.com> <20170112045019.22610-3-pat.pannuto@gmail.com> <5889CEC2.8040906@foss.arm.com>
Reply-to: newlib at sourceware dot org

On Jan 26 10:26, Kyrill Tkachov wrote:
> Here and in other places in the patch you have a syntax error in the PLD instruction.
> The syntax for the pld argument should be in square brackets as it's a memory address like so:
> pld [r1].
> With your patch the newlib build fails for armv7-a targets.
> This patch fixes the build failures.
> 
> Tested by making sure the newlib build completes successfully.
> 
> Can someone please commit it for me if it's ok for master?

Pushed.  Can you please provice patches in `git format-patch' layout in
future?  For instance, since you replied to the existing thread, the
subject in your log message needs manual intervention.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: [PATCH 2/3] arm: Remove optpld macro
  - From: Kyrill Tkachov

References:
- [PATCH 0/3] arm: Fix link time optimization issues
  - From: Pat Pannuto
- [PATCH 2/3] arm: Remove optpld macro
  - From: Pat Pannuto
- Re: [PATCH 2/3] arm: Remove optpld macro
  - From: Kyrill Tkachov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]