This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Fix padding initialization in nano_malloc?

On 12/01/2017 02:24, Joey Ye wrote:
> Thanks for this enhancement to the comments, which is clearer than the original.
> 
> Only a minor issue to me: restrictly c->size should be the next word
> after the padding, instead of the last word of the padding. After
> correcting this problem I am OK with the patch.

I'm having a hard time understanding what you mean by this? Would you mind
pointing out (or changing) the sentence or sentences that you'd like changed?

I would avoid referring to the "{last,next} word", because that makes
assumptions about the value of CHUNK_OFFSET. For example, if the type of size
were changed to short, would it still definitely be a word?

Thanks,

Joe
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]