This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Semihosting fix


Hi David,

On Apr 19 15:54, David Hoover wrote:
> Hello,
> 
> Code was introduced in commit 8d98f956cc398d086794e19051c3380d599022da
> that breaks semihosting for ARM Cortex targets running in many
> environments.
> [...]
> diff --git a/libgloss/arm/crt0.S b/libgloss/arm/crt0.S
> index 7c662f9..b459e12 100644
> --- a/libgloss/arm/crt0.S
> +++ b/libgloss/arm/crt0.S
> @@ -125,9 +125,11 @@
> 
>         /* Set __heap_limit.  */
>         ldr     r1, [r0, #4]
> +       cmp     r1, #0
> +       beq     .LC33
>         ldr     r2, =__heap_limit
>         str     r1, [r2]
> -
> +.LC33:
>         ldr     r1, [r0, #0]
>         cmp     r1, #0
>         bne     .LC32

Your patch doesn't apply cleanly because of TAB vs. SPC differences.
Can you please resend your patch with fixed formatting (git format-patch
might help)?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]