This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: newlib at sourceware dot org
- Date: Wed, 13 Apr 2016 19:15:36 +0200 (CEST)
- Subject: Re: [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t
- Authentication-results: sourceware.org; auth=none
- References: <1460545816-28369-1-git-send-email-sebastian dot huber at embedded-brains dot de> <1460545816-28369-2-git-send-email-sebastian dot huber at embedded-brains dot de> <20160413132452 dot GF30262 at calimero dot vinschen dot de> <570E4C55 dot 5030800 at embedded-brains dot de> <20160413135749 dot GB32286 at calimero dot vinschen dot de>
----- Corinna Vinschen <vinschen@redhat.com> schrieb:
> On Apr 13 15:40, Sebastian Huber wrote:
> >
> >
> > On 13/04/16 15:24, Corinna Vinschen wrote:
> > >diff --git a/winsup/cygwin/include/cygwin/types.h b/winsup/cygwin/include/cygwin/types.h
> > >index bdf4085..f9ed4b6 100644
> > >--- a/winsup/cygwin/include/cygwin/types.h
> > >+++ b/winsup/cygwin/include/cygwin/types.h
> > >@@ -32,19 +32,8 @@ typedef struct timespec timespec_t;
> > > typedef struct timespec timestruc_t;
> > > #endif /*__timestruc_t_defined*/
> > >-#ifndef __off_t_defined
> > >-#define __off_t_defined
> > >-typedef __off_t off_t;
> > >-#endif /*__off_t_defined*/
> > >-
> >
> > What I don't understand is, if you remove the off_t definition here, via
> > which include do you get it then? The <sys/types.h> seems to be not included
> > by cygwin/types.h.
>
> No, sys/types.h includes cygwin/types.h. We may want to get rid of this
> at one point in favor of only maintaining machine/_types.h, I guess....
Ok, how do you want to proceed? Should I integrate your changes into my patch set or do you want to add it yourself?
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber at embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.
- References:
- [PATCH v3 1/2] Eliminate use of Newlib-specific <machine/types.h>
- [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t
- Re: [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t
- Re: [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t
- Re: [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t