This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/2] Eliminate use of Newlib-specific <machine/types.h>

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Wed, 13 Apr 2016 11:13:52 +0200
Subject: Re: [PATCH v2 1/2] Eliminate use of Newlib-specific <machine/types.h>
Authentication-results: sourceware.org; auth=none
References: <1460532561-8466-1-git-send-email-sebastian dot huber at embedded-brains dot de>
Reply-to: newlib at sourceware dot org

On Apr 13 09:29, Sebastian Huber wrote:
> This change solves a glibc/BSD compatibility problem.
> [...]
> @@ -31,6 +38,13 @@ typedef unsigned short __gid_t;
>  __extension__ typedef long long _off64_t;
>  #endif
>  
> +/* Probably only used by Cygwin */

I don't think so.  This comment is not needed.

> +#ifdef __GNUC__
> +__extension__ typedef long long int __loff_t;
> +#else
> +typedef long int __loff_t;
> +#endif
> +

Didn't you just write in your other mail that this is a bug?  Let's fix it.
The rest of the patch looks ok.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH v2 1/2] Eliminate use of Newlib-specific <machine/types.h>
  - From: Sebastian Huber

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]