This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Properly get cygwin dir from sub-configure
- From: Jeff Johnston <jjohnstn at redhat dot com>
- To: newlib at sourceware dot org
- Date: Mon, 4 Apr 2016 17:35:59 -0400 (EDT)
- Subject: Re: [PATCH] Properly get cygwin dir from sub-configure
- Authentication-results: sourceware.org; auth=none
- References: <1459609330-15712-1-git-send-email-pefoley2 at pefoley dot com> <20160404143033 dot GF26762 at calimero dot vinschen dot de>
----- Original Message -----
> On Apr 2 11:02, Peter Foley wrote:
> > When configuring subdirs of newlib, such as libc for example, the path
> > to the winsup directory is calculated relative to the current srcdir,
> > which only works at the top-level.
> > Fix the path to be relative to newlib's top-level srcdir.
>
> Jeff, was there a reason to use srcdir instead of newlib_basedir at
> this point?
>
> /me fuzzy on autoconf stuff...
>
I didn't add that particular line. It dates back to 2003 with Chris Faylor. Configuration
in sub-directories has never worked properly usually due to missing variables set by parent levels.
-- Jeff J.
>
> Thanks,
> Corinna
>
> >
> > newlib/ChangeLog:
> > configure.host: use $newlib_basedir to calculate cygwin_srcdir
> >
> > Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> > ---
> > newlib/configure.host | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/newlib/configure.host b/newlib/configure.host
> > index 8b0846e..7ac3717 100644
> > --- a/newlib/configure.host
> > +++ b/newlib/configure.host
> > @@ -568,7 +568,7 @@ esac
> >
> > case "${host}" in
> > *-*-cygwin*)
> > - test -z "$cygwin_srcdir" && cygwin_srcdir=`cd ${srcdir}/../winsup/cygwin;
> > pwd`
> > + test -z "$cygwin_srcdir" && cygwin_srcdir=`cd
> > ${newlib_basedir}/../winsup/cygwin; pwd`
> > export cygwin_srcdir
> > default_newlib_io_c99_formats="yes"
> > default_newlib_io_long_long="yes"
> > --
> > 2.8.0
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
>