This is the mail archive of the
mailing list for the newlib project.
Re: [PATCH v2] math: guard BSD finite/isinf/isnan functions properly in math.h
- From: Yaakov Selkowitz <yselkowitz at cygwin dot com>
- To: newlib at sourceware dot org
- Date: Mon, 4 Apr 2016 15:16:49 -0500
- Subject: Re: [PATCH v2] math: guard BSD finite/isinf/isnan functions properly in math.h
- Authentication-results: sourceware.org; auth=none
- References: <1459550970-3424-1-git-send-email-yselkowi at redhat dot com> <1459798030-10720-1-git-send-email-yselkowi at redhat dot com> <5702C941 dot 4040806 at LGSInnovations dot com>
On 2016-04-04 15:06, Craig Howland wrote:
On 04/04/2016 03:27 PM, Yaakov Selkowitz wrote:
Now that we have properly functioning feature test macros, the BSD
floating-point classification functions can go into math.h instead of
the non-standard ieeefp.h, and not under the C99 guard:
The patch misses adjusting the comment at about line 212 of math.h which
points to ieeefp.h for isinf and isnan prototypes.
Thanks for catching; there are also similar comments in libm/common.
Note that the isinf and isnan functions (but not the variants) conflict
with functions by the same name in C++11, hence they (and only they)
need to be hidden:
Umm, what about the C99 isinf and isnan macros? They strictly conflict,
They do not *conflict*; the macro overrides the declaration (in the
condition that both are exposed) by virtue of being defined later.