This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Define BSD u_intN_t types indiscriminately

From: Eric Blake <eblake at redhat dot com>
To: newlib at sourceware dot org
Date: Thu, 24 Mar 2016 08:39:40 -0600
Subject: Re: [PATCH] Define BSD u_intN_t types indiscriminately
Authentication-results: sourceware.org; auth=none
Openpgp: url=http://people.redhat.com/eblake/eblake.gpg
References: <20160324100848 dot GB13802 at calimero dot vinschen dot de>

On 03/24/2016 04:08 AM, Corinna Vinschen wrote:
> Is the below patch ok?  Glibc actually always defines u_intN_t
> types, while we define them only on RTMES, XMK and Cygwin.
> 

> -/* deprecated */
> +/* BSD types, sanctioned by POSIX. */

"sanctioned" may be a bit strong; "permitted" might be better. Also,
might be worth a note that the standard types such as uint8_t should be
preferred; these BSD types are only provided for back-compat.

But otherwise the patch looks okay to me.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Follow-Ups:
- Re: [PATCH] Define BSD u_intN_t types indiscriminately
  - From: Corinna Vinschen

References:
- [PATCH] Define BSD u_intN_t types indiscriminately
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]