This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h

From: Craig Howland <howland at LGSInnovations dot com>
To: <newlib at sourceware dot org>
Date: Fri, 18 Mar 2016 12:38:36 -0400
Subject: Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
Authentication-results: sourceware.org; auth=none
References: <1458011431-9460-1-git-send-email-yselkowi at redhat dot com> <1458011431-9460-2-git-send-email-yselkowi at redhat dot com> <56E98BA9 dot 2000906 at LGSInnovations dot com> <56EA6E6F dot 8090002 at cygwin dot com> <56EAD6CF dot 4010700 at LGSInnovations dot com> <20160317212931 dot GB3097 at calimero dot vinschen dot de> <56EB63AB dot 8050007 at cygwin dot com> <20160318094708 dot GA5373 at calimero dot vinschen dot de>

On 03/18/2016 05:47 AM, Corinna Vinschen wrote:

On Mar 17 21:10, Yaakov Selkowitz wrote:

On 2016-03-17 16:29, Corinna Vinschen wrote:

Yaakov, the patch is ok to apply with just a single addition.  Please add
oneliners to the main comment in features.h to explain the _*_VISIBLE
macros, along the lines of glibc with their __USE_* macros:

Thanks, hopefully what I committed (squashed into the sys/features.h commit)
will meet these criteria.

Well done.  Thanks for this patch series which was a long overdue
improvement to newlib's headers, and thanks for the descriptive
text explaining the _*_VISIBLE macros.

Yes, well done and a big thank you for adding the descriptions.
Craig

References:
- [PATCH v3 00/24] Feature test macros overhaul
  - From: Yaakov Selkowitz
- [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
  - From: Yaakov Selkowitz
- Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
  - From: Craig Howland
- Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
  - From: Yaakov Selkowitz
- Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
  - From: Craig Howland
- Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
  - From: Corinna Vinschen
- Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
  - From: Yaakov Selkowitz
- Re: [PATCH v3 01/24] Feature test macros overhaul: sys/features.h
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]