Re: [PATCH v3 23/24] Feature test macros overhaul: sys/types.h

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 15 12:58, Corinna Vinschen wrote:
> On Mar 14 22:10, Yaakov Selkowitz wrote:
> > The u_int/u_char/etc. BSD types are needed by Cygwin's netinet/*.h
> > headers, so they always need to be available.
> > 
> > Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
> > ---
> >  newlib/libc/include/sys/types.h | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/newlib/libc/include/sys/types.h b/newlib/libc/include/sys/types.h
> > index c9f0fc7..c09866b 100644
> > --- a/newlib/libc/include/sys/types.h
> > +++ b/newlib/libc/include/sys/types.h
> > @@ -84,13 +84,14 @@ typedef	quad_t *	qaddr_t;
> >  #define _ST_INT32
> >  #endif
> >  
> > -# if	__BSD_VISIBLE
> > -
> > +#if __BSD_VISIBLE
> >  #include <sys/select.h>
> > -
> >  #  define	physadr		physadr_t
> >  #  define	quad		quad_t
> > +#endif
> >  
> > +/* These types are required by netinet/*.h on Cygwin */
> 
> That's ok for now but we should probably fix this in the Cygwin
> headers to use u_int[N]_t ASAP.

Incidentally, glibc's netinet/ip.h still uses u_short as well.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature