This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Remove broken ieeefp.h macros

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Fri, 12 Feb 2016 14:14:42 +0100
Subject: Re: [PATCH 2/2] Remove broken ieeefp.h macros
Authentication-results: sourceware.org; auth=none
References: <1455244048-8896-1-git-send-email-yselkowi at redhat dot com> <1455244048-8896-2-git-send-email-yselkowi at redhat dot com>
Reply-to: newlib at sourceware dot org

On Feb 11 20:27, Yaakov Selkowitz wrote:
> Any attempt to use isnanf, isinff, or finitef from <ieeefp.h> on
> platforms other than SPU result in a "lvalue required as unary '&'
> operand" error.
> 
> 	newlib/libc/
> 	* include/ieeefp.h (__ieeefp_isnanf): Remove broken macro.
> 	(__ieeefp_isinff, __ieeefp_finitef): Ditto.

This one puzzles me.  How is just removing the macros going to help,
other than avoiding a compiler warning?  Wouldn't the right thing to
do to fix the macros for GCC-5 or provide the functionality otherwise?

Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: [PATCH 2/2] Remove broken ieeefp.h macros
  - From: Yaakov Selkowitz

References:
- [PATCH 1/2] Fix compile with GCC 5 -Werror
  - From: Yaakov Selkowitz
- [PATCH 2/2] Remove broken ieeefp.h macros
  - From: Yaakov Selkowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]