This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH 3/5] [ARM] Rename strlen to strlen-stub.c
- From: Richard Earnshaw <Richard dot Earnshaw at foss dot arm dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at arm dot com>, "newlib at sourceware dot org" <newlib at sourceware dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Fri, 13 Nov 2015 13:40:22 +0000
- Subject: Re: [PATCH 3/5] [ARM] Rename strlen to strlen-stub.c
- Authentication-results: sourceware.org; auth=none
- References: <5645D1FA dot 6000104 at arm dot com>
On 13/11/15 12:05, Marcus Shawcroft wrote:
> In order to maintain consistency both within machine/arm and between
> machine/arm and machine/aarch64, rename the 'c' stub to -stub.c.
>
> Tested by building newlib and comparing libc.a binaries before and
> after for all permutations of:
>
> Architectures:
> armv4 armv4t armv5 armv5t armv5te armv6 armv6j armv6k
> armv6z armv6kz armv6t2 armv6-m armv6s-m armv7 armv7-a
> armv7ve armv7-r armv7-m armv7e-m armv8-a iwmmxt iwmmxt2
>
> ISAs:
> thumb arm
>
> Optimization Levels:
> Os O2
>
> Excluding:
> armv6s-m -mthumb
> armv6-m -mthumb
>
> armv6zk -mthumb
> armv6z -mthumb
> armv6k -mthumb
> armv6j -mthumb
>
> OK ?
>
> /Marcus
>
> * libc/machine/arm/Makefile.am: Rename strlen.c to strlen-stub.c
> * libc/machine/arm/Makefile.in: Regenerate.
> * libc/machine/arm/strlen.c: Rename to...
> * libc/machine/arm/strlen-stub.c: ... this.
>
>
> 0003-ARM-Rename-strlen-to-strlen-stub.c.patch
>
>
> diff --git a/newlib/ChangeLog b/newlib/ChangeLog
> index fcc9154..7c2f38a 100644
> --- a/newlib/ChangeLog
> +++ b/newlib/ChangeLog
> @@ -1,5 +1,12 @@
> 2015-11-13 Marcus Shawcroft <marcus.shawcroft@arm.com>
>
> + * libc/machine/arm/Makefile.am: Rename strlen.c to strlen-stub.c
> + * libc/machine/arm/Makefile.in: Regenerate.
> + * libc/machine/arm/strlen.c: Rename to...
> + * libc/machine/arm/strlen-stub.c: ... this.
> +
> +2015-11-13 Marcus Shawcroft <marcus.shawcroft@arm.com>
> +
OK.
R.