This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: unsetenv() patch for TZ

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Tue, 31 Mar 2015 11:28:06 +0200
Subject: Re: unsetenv() patch for TZ
Authentication-results: sourceware.org; auth=none
References: <3862C5643B15B6468269546753EB2A92055821DD at BLTSXVS01 dot govsolutions dot com> <20110709121946 dot GM4726 at calimero dot vinschen dot de> <51B1001E dot 9000805 at LGSInnovations dot com> <20130607102308 dot GA32420 at calimero dot vinschen dot de> <55196E10 dot 7050705 at LGSInnovations dot com> <20150330193057 dot GD13285 at calimero dot vinschen dot de> <20150330194516 dot GE13285 at calimero dot vinschen dot de> <5519AFC7 dot 2050002 at LGSInnovations dot com>
Reply-to: newlib at sourceware dot org

On Mar 30 16:19, Craig Howland wrote:
> 
> On 03/30/2015 03:45 PM, Corinna Vinschen wrote:
> >On Mar 30 21:30, Corinna Vinschen wrote:
> >>On Mar 30 11:38, Craig Howland wrote:
> >>>On 06/07/2013 06:23 AM, Corinna Vinschen wrote:
> >>Btw., was there some (historical?) reason that _setenv_r called tzset,
> >>and not _tzset_r?
> >
> Patch modified to call _tzset_r() instead of tzset(), to save that 1 level
> of overhead.  (Pending the general lock question.)
> 

Original patch applied.  I didn't realize that the localtime_r function
has nothing to do with struct reent, so the call to _tzset_r is not
required.  I applied my changes to avoid multiple locking on top of
that.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpnw30Tokqc4.pgp
Description: PGP signature

References:
- Re: unsetenv() patch for TZ
  - From: Craig Howland
- Re: unsetenv() patch for TZ
  - From: Corinna Vinschen
- Re: unsetenv() patch for TZ
  - From: Corinna Vinschen
- Re: unsetenv() patch for TZ
  - From: Craig Howland

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]