This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] Secure newlib stdio functions against thread cancellation (was Re: newlib stdio and thread cancellation)
On May 31 07:56, Hans-Peter Nilsson wrote:
> On May 29 09:27, Corinna Vinschen wrote:
> > * libc/stdio/local.h (_newlib_flockfile_start): New macro to
> > secure stream related critical section against thread cancellation.
> > (_newlib_flockfile_exit): Ditto.
> > (_newlib_sfp_lock_end): Ditto.
> > (_newlib_sfp_lock_start): Ditto for the list of streams.
> > (_newlib_sfp_lock_exit): Ditto.
> > (_newlib_sfp_lock_end): Ditto.
> > Use aforementioned macros in place of _flockfile/_funlockfile
> > and __sfp_lock_acquire/__sfp_lock_release throughout the code.
>
> Looks like a typo: no _newlib_sfp_lock_exit definition in the
> #else arm below, but two _newlib_sfp_lock_end.
> [...]
> This shows up in my gcc autotester when testing a newlib-update
> candidate as follows:
>
> /tmp/hpautotest-gcc47/gcc/newlib/libc/stdio/findfp.c:124:
> undefined reference to `_newlib_sfp_lock_exit'
> collect2: error: ld returned 1 exit status
>
> Can you please fix? Thanks.
Done.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat