This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH CR16] Added some missing instructions
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: Sandeep Kumar Singh <Sandeep dot Singh2 at kpitcummins dot com>
- Cc: "newlib at sourceware dot org" <newlib at sourceware dot org>, "Jayant R. Sonar" <Jayant dot Sonar at kpitcummins dot com>, Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>
- Date: Thu, 3 May 2012 17:18:15 +0200
- Subject: Re: [PATCH CR16] Added some missing instructions
- References: <00D82FEA4EAEB64782676AD908D06E6F160A433A@KCHJEXMB01.kpit.com>
- Reply-to: newlib at sourceware dot org
Hi Sandeep,
On May 3 09:52, Sandeep Kumar Singh wrote:
> Hi,
>
> Please find the attached patch "cr16-newlib.patch" for cr16 target. It adds
> some missing instructions, removes few un-supported ones and fixes constraints
> of few other instructions.
>
> Please review the patch and let me know if there should be any modifications
> in it.
>
> newlib/ChangeLog
>
> 2012-05-03 Sandeep Kumar Singh <Sandeep.Singh2@kpitcummins.com>
>
> * libc/machine/cr16/asm.h: Added some missing instructions
> and removed few unsupported instructions of cr16 target.
I'm a bit puzzled. You're removing instructions from this file, which
were available since 2010. I'm not sure this is feasible. Wouldn't
that potentially break existing code?
Can you please explain the background why instructions, which were
supposedly available since 2010 are suddenly "unsupported"?
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat