This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Support %m in printf functions


On Jan 12 05:35, Yaakov (Cygwin/X) wrote:
> On Thu, 2012-01-12 at 11:09 +0100, Corinna Vinschen wrote:
> > On Jan  9 18:22, Yaakov (Cygwin/X) wrote:
> > > On Mon, 2012-01-09 at 12:51 +0100, Corinna Vinschen wrote:
> > > > IMHO, it doesn't feel right to add __CYGWIN__ here since the %m
> > > > functionality is sufficiently target agnostic to be useful for everyone
> > > > who would like to use it.  I guess _GLIBC_EXTENSION sounds about right,
> > > > but maybe it should be _NO_GLIBC_EXTENSIONS instead and only set it
> > > > for builds which explicitely don't want them?
> > > 
> > > What about #if _ELIX_LEVEL >= 4?
> > 
> > I don't think that's feasible.  Let's use the _GLIBC_EXTENSION macro.
> > For Cygwin we should set it in winsup/cygwin/include/cygwin/config.h.
> 
> Revised patch for newlib and patch for winsup/cygwin attached.

Thanks.  Please apply.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]