Re: SPARC Leon baremetal layer

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday 30 November 2011 05:20:47 Konrad Eisele wrote:
> libgloss/{ => sparc_leon}/configure

generally, changes for the generated files should not be included.  just note 
in your ChangeLog something like:
	* configure: Regenerate.

along those lines, you'll need a ChangeLog file and updates to 
libgloss/ChangeLog in the GNU style ...

> --- a/libgloss/configure.in
> +++ b/libgloss/configure.in
> 
> ... | sparc-*leon*-none**)

that double ** is meaningless.  you want just one *.

> --- /dev/null   
> +++ b/libgloss/sparc_leon/Makefile.in
> 
> +install: 
> +   if [ -z "$(MULTISUBDIR)" ]; then \   
> +    $(mkinstalldirs) $(DESTDIR)$(tooldir)/include/asm-leon; \
> +    for i in $(srcdir)/asm-leon/*.h; do \
> +     if [ -f $$i ]; then \   
> +      $(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/include/asm-leon/`basename 
$$i`; \
> +     else true; fi ; \
> +    done; \  
> +   else true; fi

seems to have a common mistake -- there's no error checking.  use `set -e` at 
the top of this rule, or add "|| exit $$?" to that INSTALL_DATA line.

> +#link.o: ${srcdir}/../link.c
> +#  $(CC) $(CFLAGS_FOR_TARGET) -O2 $(INCLUDES) -c $(CFLAGS) $?

delete dead code

> +  if (LEON3_BYPASS_LOAD_PA(address)) \
> +  { \

the brace style is:
if (...)
  {
they should not be at the same indentation level
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.