This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Add Epiphany newlib & libgloss port


Joern Rennecke wrote:
> Quoting Jim Meyering <jim@meyering.net>:
>
>> I see no changes under /libgloss, so perhaps you
>> weren't addressing me.  For example, open is still buggy:
>
> You must be looking at a copy of that file from the old attachment.
>
> The new one has:
>
> int __attribute__ ((section ("libgloss_epiphany")))
> _open (const char *file, int flags, mode_t mode)
> {
>   return asm_syscall (file, flags, mode, SYS_open);
> }       /* _open () */

Whoa.

I went back over the steps I took and found no fault.
I started with epiphany-newlib-port-20111110.tar.xz (not the 05
tarball), untar'd it without diagnostic and catted
libgloss/epiphany/open.c.

There was no fault with those steps, but there was a mistake nonetheless.
Two things conspired to make the above fail:
I had an existing libgloss directory, and I set the TAR_OPTIONS envvar:

    $ env|grep TAR                                                               :
    TAR_OPTIONS=--keep-old-files --no-same-permissions

FYI, I started using that after seeing how a malicious tarball
could exploit some old versions of gnu tar.  But I would not
recommend it.  Many tools expect tar to replace existing files,
so I regularly find myself running things with "TAR_OPTIONS=",
to clear it.

Anyway, I am looking at the diffs, now...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]