This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH libgloss/arm] discourge the use of blx when it's not supported
- From: Can Finner <can dot finner at gmail dot com>
- To: Bin Cheng <bin dot cheng at arm dot com>
- Cc: newlib at sources dot redhat dot com, nickc at redhat dot com
- Date: Wed, 28 Sep 2011 11:14:01 +0800
- Subject: Re: [PATCH libgloss/arm] discourge the use of blx when it's not supported
- References: <4e804f68.a3b6ec0a.59c5.ffffeea6SMTPIN_ADDED@mx.google.com>
On Mon, Sep 26, 2011 at 6:09 PM, Bin Cheng <bin.cheng@arm.com> wrote:
> Hi,
>
> Ping...
>
> Thanks
>
>> -----Original Message-----
>> From: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org] On
>> Behalf Of Bin Cheng
>> Sent: Tuesday, September 20, 2011 5:01 PM
>> To: newlib@sources.redhat.com
>> Cc: nickc@redhat.com
>> Subject: [PATCH libgloss/arm] discourge the use of blx when it's not
> supported
>>
>> Hi,
>> In libgloss/arm/crt0.S, the blx is used when (__thumb__ ) || (__thumb2__)
>> defined, unfortunately it breaks compilation of libgloss for targets which
> do
>> not support it, like armv4t.
>> Moreover this patch clears the use of blx on all arm targets.
>>
>> Is it OK?
>>
>> Thanks-chengbin
>>
>> 2011-09-20 Bin Cheng <bin.cheng@arm.com>
>>
>> libgloss/
>> ? ? ? ? ? ? ? ? ?* arm/crt0.S: Don't use blx for pre-armv5 targets.
>
Hi Nick,
Could you help review this patch? It fixes the compilation failure for
armv4t version lib.
Thanks very much.
--
Regards.