This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Redefinition of PTHREAD_MUTEX_xxx
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: newlib at sourceware dot org
- Cc: Ralf Corsepius <ralf dot corsepius at rtems dot org>
- Date: Mon, 1 Aug 2011 14:09:50 +0200
- Subject: Re: Redefinition of PTHREAD_MUTEX_xxx
- References: <4E331BF8.1050307@oarcorp.com>
- Reply-to: newlib at sourceware dot org
On Jul 29 15:45, Joel Sherrill wrote:
> Hi,
>
> I noticed something I think is redundant
> and useless in sys/types.h.
>
> There is a block of code conditional
> on XMK and RTEMS which defines
> PTHREAD_MUTEX_NORMAL, PTHREAD_MUTEX_RECURSIVE,
> PTHREAD_MUTEX_ERRORCHECK, and
> #define PTHREAD_MUTEX_DEFAULT.
>
> Later there is a block of code conditional
> on _UNIX98_THREAD_MUTEX_ATTRIBUTES which
> redefines them different values.
>
> As best I can tell, both RTEMS and XMK
> define _UNIX98_THREAD_MUTEX_ATTRIBUTES
> so trip both blocks of code.
>
> The first has comments on the constants
> while the second (UNIX98) block does not.
>
> With confirmation that both XMK and
> RTEMS trip both blocks and the first is
> useless, I propose the following:
>
> + move the comments from the first
> to the second block
> + remove the first block
>
> Can I get a doublecheck on the analysis
> and then I will submit a patch.
I have a deja-vu...
Right, this has been discussed already on this list, see the thread
starting here:
http://sourceware.org/ml/newlib/2011/msg00084.html
So, given http://sourceware.org/ml/newlib/2011/msg00103.html
we're still waiting for a reply from Ralf.
Ralf? Could you please have a look?
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat