This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] libgloss: don't ignore errors in subdir build/installs
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: newlib at sourceware dot org
- Date: Mon, 10 Jan 2011 13:08:41 +0100
- Subject: Re: [PATCH] libgloss: don't ignore errors in subdir build/installs
- References: <201012201753.33395.vapier@gentoo.org>
- Reply-to: newlib at sourceware dot org
On Dec 20 17:53, Mike Frysinger wrote:
> Currently, the status of subdirs targets when building or installing are
> ignored by the top level libgloss Makefile. So errors in arch subdirs don't
> get properly caught and people only notice when their installed compiler
> doesn't work quite right.
>
> 2010-12-20 Mike Frysinger <vapier@gentoo.org>
>
> * Makefile.in (stmp-bsp): Exit when subdirs fail.
> (install): Likewise.
>
> --- libgloss/Makefile.in 19 Jun 2009 18:18:00 -0000 1.6
> +++ libgloss/Makefile.in 20 Dec 2010 21:50:20 -0000
> @@ -104,7 +104,7 @@ stmp-bsp: force
> for dir in .. ${SUBDIRS}; do \
> if [ x$$dir != x.. ]; then \
> if [ -d $$dir ]; then \
> - (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); \
> + (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)) || exit $$?; \
> else true; fi; \
> else true; fi; \
> done
> @@ -115,7 +115,7 @@ install: force
> for dir in .. ${SUBDIRS}; do \
> if [ x$$dir != x.. ]; then \
> if [ -d $$dir ]; then \
> - (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install); \
> + (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install) || exit $$?; \
> else true; fi; \
> else true; fi; \
> done
Patch applied.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat