Re: Add strings.h

[Ralf Corsepius <ralf dot corsepius at rtems dot org>]

On 10/08/2010 06:20 PM, Jeff Johnston wrote:
> On 10/08/2010 11:36 AM, Corinna Vinschen wrote:
> > On Oct 8 17:17, Ralf Corsepius wrote:
> > > On 10/08/2010 04:45 PM, Howland Craig D (Craig) wrote:
> > > > Ralf:
> > > >
> > > > One suggestion: for the unimplemented functions, rather than #if 0 to
> > > > effectively comment them out, actually comment them out so that if
> > > > people
> > > > grep for them the results show that they are not real.
> > > >
> > > > That is, change, for example,
> > > > #if 0
> > > > /* Not implemented */
> > > > int _EXFUN(strcasecmp_l,(const char *, const char *, locale_t));
> > > > #endif
> > > >
> > > > to something like
> > > > #if 0
> > > > /* Not implemented */
> > > > /* TBD int _EXFUN(strcasecmp_l,(const char *, const char *,
> > > > locale_t)); */
> > > > #endif
> > > > [where the #if 0 could be kept, but obviously would not be needed].
> > > I am OK with either solution - Jeff, Corinna, what's your preference?
> > Can't speak for Jeff, but my preference would be to drop them entirely
> > for now. We have not a single SUSv4 locale-aware ctype and string
> > function declared or defined. Nor do we yet have a declaration or
> > definition of the related newlocale/uselocale/duplocale/freelocale
> > functions. Without even the groundwork being available, I don't think
> > it makes sense to mention these function at all.
> >
> >
> > Corinna
> I don't have a problem either way as there are only a few functions, but
> would prefer no ifdefs if they are mentioned.
>
> -- Jeff J.

Sorry it tool so long to get back at this.

Next version of the patch enclosed below, this time with all 
TBD's/ifdefs removed.

Ralf

Attachment: newlib-strings.diff
Description: Text document