Re: [PATCH] add <sys/dir.h>

[Eric Blake <eblake at redhat dot com>]

On 08/10/2010 10:14 PM, Yaakov (Cygwin/X) wrote:
> The predecessor of POSIX.1 <dirent.h> and struct dirent was 4.2 BSD's
> <sys/dir.h> and struct direct[1].  glibc[2] and the BSDs[3][4][5] still
> provide the old-style header for compatibility.
> 
> Patch attached.

> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#include <dirent.h>
> +
> +#define direct dirent
> +
> +#ifdef __cplusplus
> +}

Ouch - this is broken.  You should _never_ need to #include a system
header inside C++ guards.

<dirent.h> should be providing the C++ guards.  If it is, this instance
in <sys/dir.h> is redundant; if it isn't, then <dirent.h> needs fixing.

/me goes to check...
Hmm - <dirent.h> _is_ providing C++ guards, but then it includes
<sys/dirent.h> inside guards.  Which means <sys/dirent.h> needs fixing too.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature