Re: [PATCH, V850] Add libgloss support for V850

[Jeff Johnston <jjohnstn at redhat dot com>]

A few questions and some comments.  I cc'd Nick and DJ as they have 
performed some of the latest maintenance on sysnecv850 files and might 
have something to say about the proposed move to libgloss.

1. Why is v850ea support being removed?  Top-level files don't belong
   to newlib.  See the top-level MAINTAINERS file for info on
   who owns what files or what mailing lists need to be notified.

2. Does the gcc list know you are planning on removing v850 from newlib
   and is there a corresponding change that is occurring?
   The reason I mention this is that without a change to gcc, any v850
   users will start seeing link errors because they used to get syscalls
   thrown in when they linked in newlib.  Now linking requires
   additional reference to the new linker script sim.ld.

3. You don't need to remove libnosys support.

4. It would be good to mention that you are moving newlib files to
   libgloss in the ChangeLog entry.  Helps for tracking history.

5. Are you aware that it is possible to disable the newlib sys library
   as opposed to removing it outright via a configuration option:
   --disable-newlib-supplied-syscalls?  This allows a transition period
   if one needs to get compiler support in place without breaking
   things that assume that the syscalls will be automatically linked in.

6. You are calling your bsp library libsim.a and linker script sim.ld.
   Can it be confirmed that the moved code was targeted to run on a
   simulator vs a real board?

-- Jeff J.

On 06/08/2010 12:50 AM, Naveen H. S wrote:
> Hi,
>
> Please find attached the "v850-newlib-v850-libgloss-support.patch".
> The patch adds libgloss support for V850 target.
>
> Please review the patch and let me know if there should be any modifications in it.
>
> 2010-06-08  Naveen.H.S  naveenh1@kpitcummins.com
> 		Gina Verlekar  gina.verlekar@kpitcummins.com
>
>        * configure: Remove support for V850ea.
>        * configure.ac: Likewise.
> 	* libgloss/configure: Add libgloss support for V850.
> 	* libgloss/configure.in: Likewise.
> 	* libgloss/libnosys/configure.in: Remove support for V850
> 	* libgloss/libnosys/configure: Likewise
> 	* libgloss/v850/access.c: New file.
> 	* libgloss/v850/aclocal.m4: New.
> 	* libgloss/v850/chmod.c: New.
> 	* libgloss/v850/chown.c: New.
> 	* libgloss/v850/close.c: New.
> 	* libgloss/v850/configure: New.
> 	* libgloss/v850/configure.in: New.
> 	* libgloss/v850/crt0.S: New.
> 	* libgloss/v850/crt1.c: New.
> 	* libgloss/v850/execv.c: New.
> 	* libgloss/v850/execve.c: New.
> 	* libgloss/v850/_exit.c: New.
> 	* libgloss/v850/fork.c: New.
> 	* libgloss/v850/fstat.c: New.
> 	* libgloss/v850/getpid.c: New.
> 	* libgloss/v850/gettime.c: New.
> 	* libgloss/v850/isatty.c: New.
> 	* libgloss/v850/kill.c: New.
> 	* libgloss/v850/link.c: New.
> 	* libgloss/v850/lseek.c: New.
> 	* libgloss/v850/Makefile.in: New.
> 	* libgloss/v850/open.c: New.
> 	* libgloss/v850/pipe.c: New.
> 	* libgloss/v850/read.c: New.
> 	* libgloss/v850/sbrk.c: New.
> 	* libgloss/v850/sim.ld: New.
> 	* libgloss/v850/stat.c: New.
> 	* libgloss/v850/time.c: New.
> 	* libgloss/v850/times.c: New.
> 	* libgloss/v850/trap.S: New.
> 	* libgloss/v850/unlink.c: New.
> 	* libgloss/v850/utime.c: New.
> 	* libgloss/v850/wait.c: New.
> 	* libgloss/v850/write.c: New.
> 	* newlib/configure.host: Remove V850 support.
> 	* newlib/libc/sys/configure.in: Remove v850 support.
> 	* newlib/libc/sys/sysnecv850/access.c: Remove.
> 	* newlib/libc/sys/sysnecv850/aclocal.m4: Remove.
> 	* newlib/libc/sys/sysnecv850/chmod.c: Remove.
> 	* newlib/libc/sys/sysnecv850/chown.c: Remove.
> 	* newlib/libc/sys/sysnecv850/close.c: Remove.
> 	* newlib/libc/sys/sysnecv850/configure: Remove.
> 	* newlib/libc/sys/sysnecv850/configure.in: Remove.
> 	* newlib/libc/sys/sysnecv850/creat.c: Remove.
> 	* newlib/libc/sys/sysnecv850/crt0.S: Remove.
> 	* newlib/libc/sys/sysnecv850/crt1.c: Remove.
> 	* newlib/libc/sys/sysnecv850/execv.c: Remove.
> 	* newlib/libc/sys/sysnecv850/execve.c: Remove.
> 	* newlib/libc/sys/sysnecv850/_exit.c: Remove.
> 	* newlib/libc/sys/sysnecv850/fork.c: Remove.
> 	* newlib/libc/sys/sysnecv850/access.c: Remove.
> 	* newlib/libc/sys/sysnecv850/fstat.c: Remove.
> 	* newlib/libc/sys/sysnecv850/getpid.c: Remove.
> 	* newlib/libc/sys/sysnecv850/gettime.c: Remove.
> 	* newlib/libc/sys/sysnecv850/isatty.c: Remove.
> 	* newlib/libc/sys/sysnecv850/kill.c: Remove.
> 	* newlib/libc/sys/sysnecv850/link.c: Remove.
> 	* newlib/libc/sys/sysnecv850/lseek.c: Remove.
> 	* newlib/libc/sys/sysnecv850/Makefile.am: Remove.
> 	* newlib/libc/sys/sysnecv850/Makefile.in: Remove.
>
> Thanks&  Regards,
> Naveen.H.S