This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[patch] broken nested declaration of lseek() in telldir.c

From: Ralf Corsepius <ralf dot corsepius at rtems dot org>
To: "newlib at sourceware dot org" <newlib at sourceware dot org>
Date: Sat, 06 Feb 2010 07:20:35 +0100
Subject: [patch] broken nested declaration of lseek() in telldir.c

Hi,

libc/posix/telldir.c contains a nested declaration of lseek().

This
a) doesn't match with POSIX:
off_t lseek(int fd, off_t offset, int whence);

b) causes building newlib to abort in cases when "off_t != long"

Below is my proposal to fix both issues:

Remove the nested declaration, but rely on rely on lseek() from "unistd.h", instead.

Ralf

Attachment: newlib-telldir.diff
Description: Text document

Follow-Ups:
- Re: [patch] broken nested declaration of lseek() in telldir.c
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]