This is the mail archive of the mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: General cleanup

Ken Werner wrote:
On Wednesday 26 November 2008 00:04, Howland Craig D (Craig) wrote:
The attached patch does a lot of cleanup (primarily with function
prototypes) aimed at reducing the number of compilation warnings.
(Using gcc -Wall -Wstrict-prototypes -Wmissing-prototypes, the changes
supplied get rid of ~257 warnings. 139 of them were "statement has no
effect" warnings, and almost all the rest were prototype related.) It
does not get rid of all of the prototype-related warnings, as I left
that are either of low interest or much work to fix, but I made a really
good dent in them.
Hi Craig,

I noticed you changed the signature of gettimeofday in sys/time.h. According to the Open Group specification the type of the second argument should void* or am I missing something? Here's the URL:

Hi Ken,

Thanks for catching this. I had forgotten about:

I have changed the prototype back and changed the prototype in libc/syscalls/sysgettod.c to match.

-- Jeff J.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]