This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [patch] fix printf("%p") (lesstif / XPDF crash)
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin at cygwin dot com, newlib at sourceware dot org
- Date: Sun, 27 May 2007 12:08:33 -0400
- Subject: Re: [patch] fix printf("%p") (lesstif / XPDF crash)
- References: <46598137.582DB937@dessent.net> <4659927B.3040704@byu.net>
- Reply-cc: cygwin@cygwin.com
- Reply-to: cygwin at cygwin dot com
On Sun, May 27, 2007 at 08:15:23AM -0600, Eric Blake wrote:
>According to Brian Dessent on 5/27/2007 7:01 AM:
>> Currently sprintf("%p") does not work because the path taken for
>> handling %p shares most of the code with %x but fails to populate the
>> char ox[2] used to emit the prefix, resulting in two uninitialized
>> characters being written instead of 'Ox'.
>
>Sorry about that - I missed %p when I changed the logic of %x in order to
>add %a. But your analysis is correct, and your patch looks correct too.
>Since I broke it, I'm checking in your patch as obvious.
...and I'm generating a new cygwin snapshot with the change.
Thanks Brian for tracking this down and thanks Eric for checking it in.
cgf