This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to update libtool in GCC and Src trees

Next try...

Taking Paolo's suggestion, I modified the patch to replace

if test "${use_libtool}" = "yes"; then
AC_LIBTOOL_WIN32_DLL
AM_PROG_LIBTOOL
fi

with

_LT_DECL_SED
if test "${use_libtool}" = "yes"; then
LT_INIT([shared static win32-dll])
fi

in all 15 "problematic" configure.in's, but otherwise I followed the same 10 step procedure as yesterday's attempt: http://www.cygwin.com/ml/newlib/2007/msg00533.html

The revised patch for the configure.in's is attached.

Results: exactly as hoped.

On cygwin-native, I successfully built a new cygwin kernel with its internal newlib. The build process did NOT create any libtool scripts, nor did configure run any of the libtool-related tests (except for the SED one).

On linux-native, I successfully built a shared newlib library, and the build process did create and use several libtool scripts.

So, there are just a few remaining questions:

(1) is this approach acceptable?

(2) should the ACLOCAL_AMFLAGS be updated for all 75 Makefile.am's, or just the 15 that actually need it right now?

(3) Should the configure.in's be changed to use the 'modern' libtool initialization macro LT_INIT([shared static win32-dll]) -- which will need to be committed simultaneously or as an integral part of Steve's update; or should they instead continue to use the old 'AC_LIBTOOL_WIN32_DLL; AM_PROG_LIBTOOL' macros?

(4) Once these questions are answered: Steve, do you want to 'absorb' this patch into your update, so it can be committed atomically?

--
Chuck

Index: configure.in
===================================================================
RCS file: /cvs/src/src/newlib/configure.in,v
retrieving revision 1.36
diff -u -r1.36 configure.in
--- configure.in	11 May 2007 20:09:00 -0000	1.36
+++ configure.in	16 May 2007 00:28:15 -0000
@@ -120,10 +120,10 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+_LT_DECL_SED
 AC_PROG_AWK
+if test "${use_libtool}" = "yes"; then
+LT_INIT([shared static win32-dll])
 fi
 
 AC_ARG_ENABLE(newlib_hw_fp,
Index: iconvdata/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/iconvdata/configure.in,v
retrieving revision 1.2
diff -u -r1.2 configure.in
--- iconvdata/configure.in	13 Apr 2006 19:56:23 -0000	1.2
+++ iconvdata/configure.in	16 May 2007 00:28:16 -0000
@@ -13,10 +13,9 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-
+_LT_DECL_SED 
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 AC_CONFIG_FILES([Makefile])
Index: libc/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/configure.in,v
retrieving revision 1.14
diff -u -r1.14 configure.in
--- libc/configure.in	31 Jan 2007 19:34:36 -0000	1.14
+++ libc/configure.in	16 May 2007 00:28:17 -0000
@@ -22,10 +22,9 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 AC_CONFIG_SUBDIRS(machine sys)
Index: libc/machine/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/machine/configure.in,v
retrieving revision 1.6
diff -u -r1.6 configure.in
--- libc/machine/configure.in	8 Nov 2006 19:26:43 -0000	1.6
+++ libc/machine/configure.in	16 May 2007 00:28:18 -0000
@@ -12,12 +12,11 @@
 
 dnl We have to add the following lines because automake detects the
 dnl references to libtool libraries from aclocal and tries to verify that
-dnl AM_PROG_LIBTOOL is being used.  This must be added after
-dnl the call to NEWLIB_CONFIGURE.
-
+dnl the libtool initialization macro(s) are being used.  This code must
+dnl occur after NEWLIB_CONFIGURE. 
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 if test -n "${machine_dir}"; then
Index: libc/machine/i386/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/machine/i386/configure.in,v
retrieving revision 1.3
diff -u -r1.3 configure.in
--- libc/machine/i386/configure.in	13 Apr 2006 19:56:25 -0000	1.3
+++ libc/machine/i386/configure.in	16 May 2007 00:28:21 -0000
@@ -12,12 +12,11 @@
 
 dnl We have to add the following lines because automake detects the
 dnl references to libtool libraries from aclocal and tries to verify that
-dnl AM_PROG_LIBTOOL is being used.  This code must occur after
-dnl NEWLIB_CONFIGURE. 
-
+dnl the libtool initialization macro(s) are being used.  This code must
+dnl occur after NEWLIB_CONFIGURE. 
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 AM_CONDITIONAL(MACH_ADD_SETJMP, test "x$mach_add_setjmp" = 'xtrue')
Index: libc/sys/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/sys/configure.in,v
retrieving revision 1.7
diff -u -r1.7 configure.in
--- libc/sys/configure.in	13 Apr 2006 19:56:27 -0000	1.7
+++ libc/sys/configure.in	16 May 2007 00:28:22 -0000
@@ -13,9 +13,9 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 if test -n "${sys_dir}"; then
Index: libc/sys/linux/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/sys/linux/configure.in,v
retrieving revision 1.11
diff -u -r1.11 configure.in
--- libc/sys/linux/configure.in	13 Apr 2006 19:56:30 -0000	1.11
+++ libc/sys/linux/configure.in	16 May 2007 00:28:23 -0000
@@ -13,11 +13,10 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-
-if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+_LT_DECL_SED
 AC_PROG_AWK
+if test "${use_libtool}" = "yes"; then
+LT_INIT([shared static win32-dll])
 fi
 
 LINUX_MACH_LIB=
Index: libc/sys/linux/linuxthreads/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/sys/linux/linuxthreads/configure.in,v
retrieving revision 1.2
diff -u -r1.2 configure.in
--- libc/sys/linux/linuxthreads/configure.in	13 Apr 2006 19:56:30 -0000	1.2
+++ libc/sys/linux/linuxthreads/configure.in	16 May 2007 00:28:24 -0000
@@ -13,11 +13,10 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-
-if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+_LT_DECL_SED
 AC_PROG_AWK
+if test "${use_libtool}" = "yes"; then
+LT_INIT([shared static win32-dll])
 fi
 
 if test -n "${machine_dir}"; then
Index: libc/sys/linux/linuxthreads/machine/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/sys/linux/linuxthreads/machine/configure.in,v
retrieving revision 1.3
diff -u -r1.3 configure.in
--- libc/sys/linux/linuxthreads/machine/configure.in	13 Apr 2006 19:56:30 -0000	1.3
+++ libc/sys/linux/linuxthreads/machine/configure.in	16 May 2007 00:28:25 -0000
@@ -14,8 +14,7 @@
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 if test -n "${machine_dir}"; then
Index: libc/sys/linux/linuxthreads/machine/i386/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/sys/linux/linuxthreads/machine/i386/configure.in,v
retrieving revision 1.2
diff -u -r1.2 configure.in
--- libc/sys/linux/linuxthreads/machine/i386/configure.in	13 Apr 2006 19:56:30 -0000	1.2
+++ libc/sys/linux/linuxthreads/machine/i386/configure.in	16 May 2007 00:28:26 -0000
@@ -13,11 +13,10 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-
-if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+_LT_DECL_SED
 AC_PROG_AWK
+if test "${use_libtool}" = "yes"; then
+LT_INIT([shared static win32-dll])
 fi
 
 AC_CONFIG_FILES([Makefile])
Index: libc/sys/linux/machine/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/sys/linux/machine/configure.in,v
retrieving revision 1.3
diff -u -r1.3 configure.in
--- libc/sys/linux/machine/configure.in	13 Apr 2006 19:56:30 -0000	1.3
+++ libc/sys/linux/machine/configure.in	16 May 2007 00:28:27 -0000
@@ -13,9 +13,9 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 if test -n "${machine_dir}"; then
Index: libc/sys/linux/machine/i386/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libc/sys/linux/machine/i386/configure.in,v
retrieving revision 1.2
diff -u -r1.2 configure.in
--- libc/sys/linux/machine/i386/configure.in	13 Apr 2006 19:56:30 -0000	1.2
+++ libc/sys/linux/machine/i386/configure.in	16 May 2007 00:28:28 -0000
@@ -13,11 +13,10 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-
-if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+_LT_DECL_SED
 AC_PROG_AWK
+if test "${use_libtool}" = "yes"; then
+LT_INIT([shared static win32-dll])
 fi
 
 AC_CONFIG_FILES([Makefile])
Index: libm/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libm/configure.in,v
retrieving revision 1.6
diff -u -r1.6 configure.in
--- libm/configure.in	11 Jan 2007 20:57:51 -0000	1.6
+++ libm/configure.in	16 May 2007 00:28:29 -0000
@@ -22,10 +22,9 @@
 dnl We have to enable libtool after NEWLIB_CONFIGURE because if we try and
 dnl add it into NEWLIB_CONFIGURE, executable tests are made before the first
 dnl line of the macro which fail because appropriate LDFLAGS are not set.
-
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 AC_CONFIG_SUBDIRS(machine)
Index: libm/machine/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libm/machine/configure.in,v
retrieving revision 1.5
diff -u -r1.5 configure.in
--- libm/machine/configure.in	14 Feb 2007 23:18:25 -0000	1.5
+++ libm/machine/configure.in	16 May 2007 00:28:30 -0000
@@ -12,12 +12,11 @@
 
 dnl We have to add the following lines because automake detects the
 dnl references to libtool libraries from aclocal and tries to verify that
-dnl AM_PROG_LIBTOOL is being used.  This must be added after
-dnl the call to NEWLIB_CONFIGURE.
-
+dnl the libtool initialization macro(s) are being used.  This code must
+dnl occur after NEWLIB_CONFIGURE. 
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 machlib=
Index: libm/machine/i386/configure.in
===================================================================
RCS file: /cvs/src/src/newlib/libm/machine/i386/configure.in,v
retrieving revision 1.2
diff -u -r1.2 configure.in
--- libm/machine/i386/configure.in	13 Apr 2006 19:56:32 -0000	1.2
+++ libm/machine/i386/configure.in	16 May 2007 00:28:32 -0000
@@ -12,12 +12,11 @@
 
 dnl We have to add the following lines because automake detects the
 dnl references to libtool libraries from aclocal and tries to verify that
-dnl AM_PROG_LIBTOOL is being used.  This code must occur after
-dnl NEWLIB_CONFIGURE. 
-
+dnl the libtool initialization macro(s) are being used.  This code must
+dnl occur after NEWLIB_CONFIGURE. 
+_LT_DECL_SED
 if test "${use_libtool}" = "yes"; then
-AC_LIBTOOL_WIN32_DLL
-AM_PROG_LIBTOOL
+LT_INIT([shared static win32-dll])
 fi
 
 AC_CONFIG_FILES([Makefile])
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]