This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: implement printf("%a")

Jeff Johnston <jjohnstn <at> redhat.com> writes:

> 
> Thanks Eric, that was fast.  If you have verified disabling the feature 
> builds fine, please go ahead and check it in.
> 


Yes, I tested with both cygwin (no change to the pre-patch result, thanks to 
the config.host default for cygwin), and with an explicit --disable-newlib-io-
c99-formats, and both versions compiled.  Checked in.

I did mean to ask, however, why in vfscanf.c and vfprintf.c, _NO_LONGLONG is 
dependent on using gcc, since long long is now a standardized feature of C99 
and is essential for full C99 compliance of printf, and since most non-gnu C89 
compilers also support it these days.  Should I just change

#define _NO_LONGLONG
#if defined _WANT_IO_LONG_LONG && defined __GNUC__
# undef _NO_LONGLONG
#endif

to this?

#define _NO_LONGLONG
#if defined _WANT_IO_LONG_LONG
# undef _NO_LONGLONG
#endif

-- 
Eric Blake
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]