This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: implement asnprintf, take 2


Eric Blake wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jeff Johnston on 4/30/2007 3:28 PM:
Hi Eric,

  I'm not seeing an explanation for the following code change you have
made in vfprintf.c:

@@ -1247,13 +1201,13 @@ number:                 if ((dprec = prec) >= 0)
                                if (_fpvalue == 0) {
                                        /* kludge for __dtoa
irregularity */
                                        PRINT ("0", 1);
-                                       if (expt < ndig || (flags & ALT)
!= 0) {
+                                       if (ndig || flags & ALT) {
                                                PRINT (decimal_point, 1);
                                                PAD (ndig - 1, zeroes);
                                        }

Note the check expt < ndig has been replaced with ndig.

Any other holdups from checking the rest of the patch in once this hunk is reverted?


No, please go ahead. I was looking at a more clever way to do the ELIX_LEVEL checking, but it doesn't work.


-- Jeff J.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGOdNF84KuGfSFAYARArfCAKCIsALeqlPpfpxi2iHKGlmXXDHKZwCgx+rU
Nxq9cwXtSQq7RxUBzAtV5oc=
=trnB
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]