Re: [patch] lib/flags.exp: Fix "FAIL: newlib.wctype/twctype.c"

[Jeff Johnston <jjohnstn at redhat dot com>]

Kazu Hirata wrote:
> Hi,
>
> Attached is a patch to fix
>
>   FAIL: newlib.wctype/twctype.c compilation
>
> There are two versions of newlib.h.  One is an empty file in the
> source tree.  The other is populated with macro definitions and lives
> in the installation directory.  The problem is that the testcase,
> newlib.wctype/twctype.c, is compiled with
> -I/<srcdir>/newlib/libc/include, causing the newlib.h in the source
> tree to be included.  This causes the compilation to miss the macro
> definition of _MB_LEN_MAX, which is in newlib.h in the installation
> directory.
>
> This -I comes from newlib_include_flags.  The patch simply removes it.
>
> Tested on fido-none-elf with no new regressions.  OK to apply?

Yes, and thanks.

-- Jeff J.

> Kazu Hirata
>
> newlib/
> 2007-04-04  Kazu Hirata  <kazu@codesourcery.com>
>
> 	* testsuite/lib/flags.exp (newlib_include_flags): Drop
> 	-I${newlib_dir}.
>
> Index: newlib/testsuite/lib/flags.exp
> ===================================================================
> RCS file: /cvs/src/src/newlib/testsuite/lib/flags.exp,v
> retrieving revision 1.2
> diff -u -d -p -r1.2 flags.exp
> --- newlib/testsuite/lib/flags.exp	5 Jul 2005 00:10:08 -0000	1.2
> +++ newlib/testsuite/lib/flags.exp	5 Apr 2007 13:50:58 -0000
> @@ -82,9 +82,5 @@ proc newlib_include_flags { args } {
>  	return ""
>      }
>  
> -    set newlib_dir [lookfor_file ${srcdir} newlib/libc/include/assert.h]
> -    if { ${newlib_dir} != "" } {
> -	set newlib_dir [file dirname ${newlib_dir}]
> -    }
> -    return " -I$objdir/targ-include -I${newlib_dir}"
> +    return " -I$objdir/targ-include"
>  }