This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] add base fenv and spu fenv support
Patrick Mansfield wrote:
On Wed, Feb 14, 2007 at 01:28:41PM -0500, Jeff Johnston wrote:
1. Why are you using "../headers" in your C files when the C files and
"headers" subdirectory are in the same directory?
Mainly to avoid clutter, and because the code this came from (in IBM SDK
1.1) had this separation. Plus, I plan to submit more SPU optimized math
functions (based on additional and modified SPU SIMD math functions that
are in a separate package), pretty much one for every math function, so
one header and one C file for each math function.
Do you still want them moved?
I don't really have a problem with your headers file subdirectory if you
feel it simplifies maintenance.
The C file and headers directory are in the same
subdirectory (machine/cpu). For example, you have fegetenv.c:
#include "../headers/fegetenv.h"
void fegetenv(fenv_t *envp)
{
_fegetenv(envp);
}
which is in libc/machine/spu. You have libc/machine/spu/headers
Why isn't the include statement simply:
#include "headers/fegetenv.h"
2. There is an explicit copyright in sys/fenv.h but no license.
OK.
3. I do not see any real advantage to having the fenv.h in the
main include directory since it only declares std prototypes,
doesn't work for any platform but spu and has a documentation
clause. At this time, it would be best to just place it in
machine/spu/include
OK.
-- Patrick Mansfield