RE: RDOS support

[Leif Ekblad <leif at rdos dot net>]

Jeff:
>  1. You have licensed rdos.s under the GPL not the LGPL.  This is not
>     allowed.  If you relicence the file and send it back to me, I will
>     replace it.

I've changed this.

>  2. You have licensed syscall stubs with your copyright and the LGPL.
>     The code for these stubs is trivial and already exists in numerous
>     places, including newlib docs.  I recommend simply leaving the
>     licensing out of these files.  For the files where you have
>     rdos-specific code (e.g. close.c/read.c/write.c), the license you
>     have is appropriate.

OK, I will eventually replace many of these stubs, but for the time
being they can remain stubs without headers.

>  3. You did not have a Makefile.am.  I added one in (attached) and
>     generated Makefile.in from it.

OK, thanks. I don't know how to do this properly anyway.

>  4. You have an acconfig.h file and a config.h.in, plus you have a
>     custom configure.in.  You never use any of the AC_DEFINED variables
>     in your code.  You should not have supplied a config.h as this
>     file should be generated at configuration time in the build
>     directory.  Running autoheader also gave me a different
>     config.h.in file than you provided.  A simpler
>     configure.in is used by most libc/sys directories.  Is there
>     any particular reason you needed the configure.in
>     you provided and config.h support?

No. I imported these files from another project (possibly Linux).

> I have tar'd up a version of the directory after a number of changes
> including a simpler configure.in, a Makefile.am, no acconfig.h, and a 
> stub config.h for future usage (e.g. sys/linux has a hard-coded 
> config.h it uses).
>
> Please confirm this still builds for you and inform me of any 
> issues/questions you have with my changes.

There is one minor issue with user.def. For some reason the compiler
(assembler) cannot find this file. I changed this include
to ../../../../../newlib/libc/sys/rdos/user.def. There possibly is
a better way of informing the assembler where to find this file, or
to copy it to the build directory, but I haven't found any better.
Feel free to modify this.

> If you have no issues with > the changes and it builds fine, supply me
> with a new rdos.s and I can > check the initial version of the code 
> in.

There are some additional changes in crt0.s and possibly some other
file. I enclose a new rdos.tar.bz2 that is based on your work and
updated with the issues we've found.

Regards,
Leif Ekblad

Attachment: rdos.tar.bz2
Description: application/bzip-compressed-tar