This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: patch for freopen(NULL,...)

From: Jeff Johnston <jjohnstn at redhat dot com>
To: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
Cc: newlib at sources dot redhat dot com
Date: Mon, 09 Jan 2006 15:00:41 -0500
Subject: Re: patch for freopen(NULL,...)
References: <43B015D9.5000708@byu.net> <43C2A34F.40505@redhat.com> <20060109183937.GA11859@trixie.casa.cgf.cx>

Christopher Faylor wrote:

On Mon, Jan 09, 2006 at 12:54:23PM -0500, Jeff Johnston wrote:

Patch checked in with minor modifications. A check was required for HAVE_FCNTL before using _fcntl_r. I also initialized e which was generating a warning message because of the new if clause.
.../i686-pc-cygwin/newlib/libc/libc.a(freopen.o): In function `_freopen_r':
.../newlib/libc/stdio/freopen.c:167: undefined reference to `__isatty'
.../i686-pc-cygwin/newlib/libc/libc.a(freopen64.o): In function `_freopen64_r':
.../newlib/libc/stdio64/freopen64.c:167: undefined reference to `__isatty'
Isn't that supposed to just be "isatty()" not "_isatty()"?  I'm
wondering how this could have ever been linked.
cgf

It builds and links fine under x86-linux which I usually use for my testing. I'll switch it over immediately to match the usage in libc/stdio/makebuf.c.

-- Jeff J.

References:
- Re: patch for freopen(NULL,...)
  - From: Jeff Johnston
- Re: patch for freopen(NULL,...)
  - From: Christopher Faylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]