This is the mail archive of the newlib@sources.redhat.com mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: libgloss/arm: isatty [PATCH]

From: Richard Earnshaw <rearnsha at gcc dot gnu dot org>
To: Shaun Jackman <sjackman at gmail dot com>
Cc: Nick Clifton <nickc at redhat dot com>, newlib at sources dot redhat dot com
Date: Fri, 29 Jul 2005 17:14:49 +0100
Subject: Re: libgloss/arm: isatty [PATCH]
References: <7f45d9390507281459ea46e94@mail.gmail.com> <42E9F775.3060703@redhat.com> <7f45d93905072908472c89a1b3@mail.gmail.com>

On Fri, 2005-07-29 at 16:47, Shaun Jackman wrote:
> On 7/29/05, Nick Clifton <nickc@redhat.com> wrote:
> > > +     /* GDB does not yet support the IsTTY SWI that _isatty
> > > +      * calls, so always return true for now. */
> >                                                   ^
> > Minor point: You should have two spaces at the   |  end of a comment.
> 
> I haven't run into this before. You're suggesting two spaces between
> the final period and the asterisk? I'm curious as to why.
> 
> Cheers,
> Shaun

Because that's what the GNU coding standards say.

http://www.gnu.org/prep/standards/standards.html#Comments

References:
- libgloss/arm: isatty [PATCH]
  - From: Shaun Jackman
- Re: libgloss/arm: isatty [PATCH]
  - From: Nick Clifton
- Re: libgloss/arm: isatty [PATCH]
  - From: Shaun Jackman

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]