This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: Fix Q registers parameter passing on ARM64
- From: Tom Tromey <tom at tromey dot com>
- To: Martin Bekchiev <Martin dot Bektchiev at progress dot com>
- Cc: "libffi-discuss\@sourceware.org" <libffi-discuss at sourceware dot org>
- Date: Thu, 29 Nov 2018 10:52:24 -0700
- Subject: Re: Fix Q registers parameter passing on ARM64
- References: <C388A2DD-E96E-408B-90DA-90FAEDA6D58B@progress.com>
>>>>> "Martin" == Martin Bekchiev <Martin.Bektchiev@progress.com> writes:
Martin> I opened a PR with a very small fix on ARM64 architecture about a month ago. Can someone with commit rights please review and merge it?
Martin> https://github.com/libffi/libffi/pull/457
You pinged me for review and I dropped it. Sorry about that. Emailing
here is the right thing to do.
I don't know anything about ARM64 and so I was reluctant to merge it.
Could you possibly add a new regression test? Also, I'm wondering if
you re-ran the existing test suite after your change.
Tom