This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: [PATCH] Fix dejagnu test support for --tool_opts
- From: Filipe Brandenburger <filbranden at google dot com>
- To: libffi-discuss at sourceware dot org
- Date: Tue, 9 Feb 2016 14:17:29 -0800
- Subject: Re: [PATCH] Fix dejagnu test support for --tool_opts
- Authentication-results: sourceware.org; auth=none
- References: <1454535567-9589-1-git-send-email-filbranden at google dot com>
On Wed, Feb 3, 2016 at 1:39 PM, Filipe Brandenburger
<filbranden@google.com> wrote:
> Right now it concatenates it with the existing options and then appends
> it to that list, fix it to simply append it as is, same as it is done
> with the other variables.
>
> Tested by running the following command which includes gcc options:
> $ make check RUNTESTFLAGS="--tool_opts '-Werror'"
>
> Without this patch, all the tests fail. With it, the test succeed.
> Inspecting the logs shows that -Werror was indeed used when compiling
> the test sources.
> ---
> Also available as a GitHub PR:
> https://github.com/atgreen/libffi/pull/205
>
> Re-sending it to this mailing list, in case GitHub PRs are not the best way to
> push this, and e-mail submissions are preferred.
Ping?