This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: [RFC][PATCH 1/3] Complex type support (FFI_TYPE_COMPLEX)
- From: Dominik Vogt <vogt at linux dot vnet dot ibm dot com>
- To: libffi-discuss at sourceware dot org
- Date: Wed, 23 Jul 2014 09:41:14 +0100
- Subject: Re: [RFC][PATCH 1/3] Complex type support (FFI_TYPE_COMPLEX)
- Authentication-results: sourceware.org; auth=none
- References: <20140722092734 dot GA23937 at linux dot vnet dot ibm dot com> <20140722093534 dot GA30068 at linux dot vnet dot ibm dot com>
- Reply-to: vogt at linux dot vnet dot ibm dot com
On Tue, Jul 22, 2014 at 10:35:34AM +0100, Dominik Vogt wrote:
> FFI_ASSERT_VALID_TYPE(cif->rtype);
>
> /* x86, x86-64 and s390 stack space allocation is handled in prep_machdep. */
> -#if !defined M68K && !defined X86_ANY && !defined S390 && !defined PA
> +#if !defined FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION
Just noticed that I forgot about M68K here. The correct condition
is
#if !defined M68K && !defined FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION
unless ...
> FFI_ASSERT_VALID_TYPE(*ptr);
>
> -#if !defined X86_ANY && !defined S390 && !defined PA
> +#if !defined FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION
... this condition forgets to check M68K by accident or in case it
does not matter.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany