This is the mail archive of the
libffi-discuss@sourceware.org
mailing list for the libffi project.
Re: open_temp_exec_file_mnt bug with getmntent_r
- From: Mark Wielaard <mjw at redhat dot com>
- To: libffi-discuss at sourceware dot org
- Cc: green at redhat dot com
- Date: Fri, 27 Aug 2010 11:37:38 +0200
- Subject: Re: open_temp_exec_file_mnt bug with getmntent_r
- References: <1282302302.2994.12.camel@springer.wildebeest.org>
On Fri, 2010-08-20 at 13:05 +0200, Mark Wielaard wrote:
> Probably nobody noticed before because earlier open_temp_exec_file_opts
> (TMPDIR, /tmp, /var/tmp, /dev/shm, HOME) always allow creating files.
> But if you have a weird setup that doesn't, then the
> open_temp_exec_file_mnt mount point search won't help you because the
> getmntent_r () return check is wrong. It fails when an entry is found
> instead of when no entry is found (NULL is returned).
>
> This fixes that case:
>
> 2010-08-20 Mark Wielaard <mjw@redhat.com>
>
> * src/closures.c (open_temp_exec_file_mnt): Check if getmntent_r
> returns NULL.
>
> You can also test this by commenting out the earlier
> open_temp_exec_file_opts options.
Ping. Any comments?