Re: [PATCH 5/5] NEWS: Add entries for bugs: 22848, 22932, 22937, 22963.

[Rafal Luzynski <digitalfreak@lingonborough.com>]

15.03.2018 18:39 Carlos O'Donell <carlos@redhat.com> wrote:
>
> On 03/15/2018 05:23 AM, Rafal Luzynski wrote:
> > [...]
> > +Major new features:
> > +
> > +* As a continuation of the previous work on bug 10871 (supporting
> > nominative
> > + and genitive month names) alternative month data have been added for the
> > + Catalan and Czech language. For the Catalan language the abbreviated
> > + alternative month name data has been also added. The Greek language which
> > + had had alternative month names already has received the abbreviated
> > + alternative month names.
>
> Suggest:
>
> * Nominative and genitive month names are now supported for the Catalan and
> Czech languages. The Catalan and Greek languages now support abbreviated
> alternative month names.

Thank you Carlos for this review and thank you Joseph for the discussion.
Is "supported"/"support" the correct word?  IIUC this sounds like a new
software feature while I'm only adding new data.  Wouldn't "provided" be
better, or "added" or "included"?  Also I think it would be better to use
the consequent wording "nominative/genitive" vs. "alternative".

Just please confirm if "supported" is correct.

> [...]
> If these bug fixes need a news entry, then there should be a news entry in
> glibc
> master NEWS *first* before you add it here.

OK, good point.

> > [...]
> > + [22848] ca_ES: update date definitions from CLDR
>
> Not marked fixed in 2.28 (target milestone should be set to 2.28 and marked
> fixed).

I was going to ask if it should be marked as fixed in 2.28 or 2.27.1
(there is no such option in Bugzilla) or 2.27.  Also I was going to mark
as fixed after pushing to 2.27.  The same about other bugs.

> [...]
> Next steps:
>
> - Commit a NEWS update to glibc master.
> - Mark all bugs fixed with milestone set to glibc 2.28.
> - Commit the same NEWS entry in 2.27.
> - Commit all the changes (will automatically add comments to bugzilla
> that they were also fixed in release/2.27/master).

OK, just please confirm the correct wording in NEWS and the correct
target milestone in Bugzilla.

Regards,

Rafal