This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] ARM: Fix clone code when built for Thumb.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: <libc-ports at sourceware dot org>, <patches at linaro dot org>
- Date: Thu, 29 Aug 2013 19:26:22 +0000
- Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb.
- Authentication-results: sourceware.org; auth=none
- References: <521F9E4E dot 5040906 at linaro dot org>
On Thu, 29 Aug 2013, Will Newton wrote:
> The mov lr, pc instruction will lose the Thumb bit from the return address
> so use blx lr instead.
>
> ports/ChangeLog.arm:
>
> 2013-08-29 Will Newton <will.newton@linaro.org>
>
> * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
> instead of mov lr, pc.
OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and
addition of the fixed bug number to NEWS. Since this is a regression
arising from the changes to build .S files as Thumb, you should also
cherry-pick the fix to 2.18 branch.
--
Joseph S. Myers
joseph@codesourcery.com